Basic support of custom post types #25157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30587 | |
| Version | PR #25157 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5070ed6 | |
| Installation URL | 2ouhd2bh8m518 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30587 | |
| Version | PR #25157 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5070ed6 | |
| Installation URL | 1lk04dd38f2q8 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
kean
reviewed
Jan 22, 2026
| return TaggedManagedObjectID(blog) | ||
| } | ||
| case let .selfHosted(id, _, _, _): | ||
| case let .selfHosted(id, _, _, _, _): |
Contributor
There was a problem hiding this comment.
(nit) would be nice to wrap this associated values in a struct
kean
reviewed
Jan 22, 2026
| import WebKit | ||
| import DesignSystem | ||
|
|
||
| class SimpleGBKViewController: UIViewController { |
Contributor
There was a problem hiding this comment.
Is the editor used for custom posts? Would it work to parameterize the current editor (NewGutenbergViewController) to work with these posts?
Contributor
Author
There was a problem hiding this comment.
Yes, that'd be the next step. The SimpleGBKViewController was created to quickly test editing custom posts in GBK editor.
crazytonyli
force-pushed
the
prototype-custom-post-types
branch
from
af4e4b9 to
014b963
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds basic support for custom post types, which is behind a local feature flag (on by default in debug builds).
Please note that, during development, I found a few parsing issues. I suspect there are more. We'll need to try a few more plugins that register custom post types (see 1 below).
Supported features:
Testing instructions
You can use cpt.wpmt.co to view the books on the site. Please note that not all books can be loaded (see p1768466053646389-slack-C06S1QS55K9).
You can install WP Job Manager on test sites, which registers a "job listing" custom post type.